Skip to content

Fix open Greptile P1 review items - #10

Merged
chiruu12 merged 1 commit into
mainfrom
fix/greptile-review-items
Jun 11, 2026
Merged

Fix open Greptile P1 review items#10
chiruu12 merged 1 commit into
mainfrom
fix/greptile-review-items

Conversation

@chiruu12

Copy link
Copy Markdown
Collaborator

Summary

Addresses the six Greptile P1 items still open on main after PRs #2-#4 (PR #7 had no Greptile review):

  • Judge deadlock: InputPipeline._maybe_judge now uses run_coroutine_sync instead of run_coroutine_threadsafe on the caller loop thread
  • Pipe evasion vs shell pipes: removed unconditional | strip; keep alpha|alpha plus letter|space and space|letter evasion passes while preserving ls | grep
  • SSN false positives: dropped redundant ssn_compact and reject invalid SSN area codes (000/666/9xx) in the main ssn pattern
  • Secrets sanitize: merge overlapping generic spans before redaction
  • Base64 decode cap: iter_base64_blobs skips decoded payloads over 10KB (matches normalize)
  • PyPI publish: uv publish --check-url so release re-runs skip already-uploaded versions

Test plan

  • make check-ci green locally (635 tests)
  • New coverage: asyncio bridge, pipe evasion/shell pipe, overlapping secrets, oversized base64, SSN area validation
  • CI green on PR

Copilot AI review requested due to automatic review settings June 11, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chiruu12
chiruu12 merged commit 6c92927 into main Jun 11, 2026
1 check passed
@chiruu12

Copy link
Copy Markdown
Collaborator Author

Greptile P1 audit complete. All six open items from PRs #2-#4 are fixed in 6d77161:

Item Fix
Judge deadlock (input.py) run_coroutine_sync()
Pipe strip false negatives (normalize.py) Selective evasion passes, shell pipes preserved
ssn_compact false positives (leakage.py) Removed redundant pattern; invalid SSN areas rejected
Overlapping secrets spans (secrets.py) _merge_spans() before redaction
Base64 decode cap (encodings.py) 10KB limit in iter_base64_blobs
PyPI re-publish (publish-pypi.yml) uv publish --check-url

Replied in the original Greptile threads on PR #4. PR #7 had no Greptile review (Copilot quota only).

@chiruu12 chiruu12 mentioned this pull request Jun 11, 2026
3 tasks
@chiruu12
chiruu12 deleted the fix/greptile-review-items branch June 12, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants